.NET Add Style and Quality Parameters Support with Execution Settings #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the GetImageContentsAsync method to the OpenAITextToImageService class.
- Implemented validation for input, including width, height, quality, and style settings.
- Supported image sizes include 256x256, 512x512, 1024x1024, 1792x1024, and 1024x1792.
- Added checks for supported qualities ('standard', 'hd') and styles ('vivid', 'natural').
- Constructed the request body for image generation and processed the response to handle both URLs and base64-encoded images.
- Converted image strings into ImageContent objects, ensuring proper handling of data URIs and HTTP URLs.
- Implemented unit tests for the GetImageContentsAsync method in OpenAITextToImageService. - Added a test to verify that the method returns expected ImageContent when provided with valid input. - Added parameterized tests using [Theory] and [InlineData] to cover a variety of scenarios: - Valid URL and base64 image data inputs. - Validation of input sizes, quality, and style parameters. - Ensured NotSupportedException is thrown for unsupported sizes, quality, and style. - Tests ensure that both HTTP URLs and base64-encoded images are handled correctly, with proper assertions on the returned ImageContent objects.
aghimir3
changed the title
aghimir3
changed the title
|
@RogerBarreto PR ready :) |
RogerBarreto
approved these changes
Aug 14, 2024
|
Thanks for the contribution @aghimir3 ! |
RogerBarreto
merged commit 9a47d7c
into
RogerBarreto:issues/5657-itexttoimage-update
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required?
This change is required to introduce the use of
styleandqualityparameters in image generation, along with the usage ofOpenAITextToImageExecutionSettingswithin theOpenAITextToImageService.What problem does it solve?
The implementation enables the
OpenAITextToImageServiceto handle additional parameters (styleandquality), allowing for more customized image generation requests. It also streamlines the integration withOpenAITextToImageExecutionSettings, making the service more flexible and configurable.What scenario does it contribute to?
This contributes to scenarios where users need to generate images with specific styles and qualities, enhancing the functionality and usability of the
OpenAITextToImageService.If it fixes an open issue, please link to the issue here.
This implementation fixes issue #7086 and #5657
Description
This PR enhances the
OpenAITextToImageServiceby:styleandqualityparameters, allowing users to generate images with specific artistic styles and quality levels.OpenAITextToImageExecutionSettings: The service now utilizesOpenAITextToImageExecutionSettingsfor handling execution parameters, improving the overall flexibility and configurability of image generation requests.styleandqualityparameters to ensure only supported values are used.styleandqualityparameters, as well as the general functionality of the service with various settings.Contribution Checklist